Skip to content

feat(validation): add Exists validation rule #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
innocenzi merged 3 commits into from
Aug 15, 2025
Merged

feat(validation): add Exists validation rule #1462

innocenzi merged 3 commits into from
Aug 15, 2025

Conversation

@Treggats
Copy link
Contributor

@Treggats Treggats commented Aug 6, 2025 •
edited
Loading

Working on a application I was missing an exists validation rule.

This PR adds it.

@Treggats Treggats force-pushed the add-exists-validation-rule branch 2 times, most recently from d23ecc6 to 384fb55 Compare August 6, 2025 23:23
@Treggats Treggats changed the title feat(validation): add Exists validation rule feat(validation): add Exists validation rule Aug 6, 2025
@Treggats Treggats force-pushed the add-exists-validation-rule branch 8 times, most recently from 33f7881 to 4ec3e49 Compare August 7, 2025 00:27
@Treggats Treggats marked this pull request as ready for review August 7, 2025 00:32
@innocenzi innocenzi marked this pull request as draft August 7, 2025 21:53
@innocenzi
Copy link
Member

innocenzi commented Aug 7, 2025

Let's wait for #1444 to be merged 👍

(that description does not help, it's a lot of noise :))

@Treggats
Copy link
Contributor Author

Treggats commented Aug 8, 2025 •
edited
Loading

Let's wait for #1444 to be merged 👍

💯 could probably also remove the version check in that case 😄

(that description does not help, it's a lot of noise :))

Yeah, kinda suspected that, will remove it

@Treggats Treggats force-pushed the add-exists-validation-rule branch 2 times, most recently from f382a52 to 71c0c22 Compare August 12, 2025 17:03
@brendt brendt changed the base branch from main to 2.x August 13, 2025 08:59
@Treggats Treggats force-pushed the add-exists-validation-rule branch from 71c0c22 to 8708aee Compare August 13, 2025 12:58
@innocenzi
Copy link
Member

innocenzi commented Aug 13, 2025

Actually, let's wait for #1458 to be merged, due to the id stuff. I'll adapt the PR when it's merged

@Treggats
Copy link
Contributor Author

Treggats commented Aug 13, 2025

@innocenzi

Actually, let's wait for #1458 to be merged, due to the id stuff. I'll adapt the PR when it's merged

Alright then, sounds good!

@innocenzi innocenzi force-pushed the add-exists-validation-rule branch from 8708aee to 3349ded Compare August 15, 2025 18:37
@innocenzi innocenzi marked this pull request as ready for review August 15, 2025 18:37
@innocenzi
Copy link
Member

innocenzi commented Aug 15, 2025

After working on this PR, I assume a few tests were also LLM-generated because they were redundant :p

I rebased the PR on 2.x, I made the rule work with tables and allowed specifying the column to check, and moved the test you placed in http in the validator directory 👍

@innocenzi innocenzi merged commit a28c943 into tempestphp:2.x Aug 15, 2025
77 checks passed
@Treggats Treggats deleted the add-exists-validation-rule branch August 15, 2025 19:58
Bapawe pushed a commit to Bapawe/tempest-framework that referenced this pull request Aug 29, 2025
@Treggats @innocenzi @Bapawe
feat(validation): add Exists validation rule (tempestphp#1462)
c8e4d13 
Co-authored-by: Enzo Innocenzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Treggats @innocenzi